Fix versions in requirements.txt for python 3.5 and 3.9 #20507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
bug
review
:Testing
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
ChrsMark
approved these changes
Aug 10, 2020
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Log outputExpand to view the last 100 lines of log output
|
jsoriano
added
the
needs_backport
ChrsMark
reviewed
Aug 10, 2020
ChrsMark
approved these changes
Aug 10, 2020
|
Failing test is fixed in master, merging. |
|
Will apply the changes in 7.x branch on the backport PR for pytest #20478 |
jsoriano
removed
the
needs_backport
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Packages listed in current requirements.txt file cannot be installed in python 3.5 and 3.9: * Pillow doesn't have a candidate for 3.9, it was already removed in elastic#20407, but added again by mistake in elastic#16883. * zipp package needed by pytest works with different versions depending on the version of python, version that works with python 3.5 doesn't work with other versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix versions of packages in
requirements.txtfile so they can be installed in all python versions from 3.5 to 3.9.Added a cleaned-up version of a one-liner I was using to check the
requirements.txtfile with different versions.Why is it important?
Packages listed in current
requirements.txtfile cannot be installed in python 3.5 and 3.9:zipppackage needed bypytestworks with different versions depending the version of python, version that works with python 3.5 doesn't work with other versions.We still need to support python 3.5 because it is used in some CI workers.